Re: patch : Allow toast tables to be moved to a different tablespace

From: Julien Tachoires <julmon(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jaime Casanova <jaime(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
Date: 2011-12-13 17:29:56
Message-ID: CAFEQCbESRGXLE4+tRAnazr8QmBJzfYPwc6GP1Daq0quyuyEpZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2011/12/13 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Tue, Dec 13, 2011 at 12:02 PM, Julien Tachoires <julmon(at)gmail(dot)com> wrote:
>> Right, it seems to happen when the destination tablespace is the same
>> as the database's tbs, because, in this case, relation's tbs is set to
>> InvalidOid :
>> src/backend/commands/tablecmds.c line 8342
>>
>> +       rd_rel->reltablespace = (newTableSpace == MyDatabaseTableSpace) ?
>> InvalidOid : newTableSpace;
>>
>> Why don't just asign newTableSpace value here ?
>
> When a relation is stored in the default tablespace, we always record
> that in the system catalogs as InvalidOid.  Otherwise, if the
> database's default tablespace were changed, things would break.

OK, considering that, I don't see any way to handle the case raised by Jaime :(

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-12-13 17:30:01 Re: libpq: PQcmdStatus, PQcmdTuples signatures can be painlessly improved
Previous Message Christopher Browne 2011-12-13 17:29:04 Re: Command Triggers