Re: libpq version macro to use or not PQsocketPoll

On Tue, Aug 6, 2024 at 4:48 PM Dominique Devienne <ddevienne(at)gmail(dot)com> wrote:
> On Tue, Aug 6, 2024 at 4:31 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Dominique Devienne <ddevienne(at)gmail(dot)com> writes:
> > Indeed, that's an oversight, and there's a number of other things
> > we added to libpq-fe.h between 16 and 17 that probably deserve
> > their own LIBPQ_HAS symbols.

Hi. Doesn't look like beta3 _has_ them (pun indented :)).
Was probably too late for the beta3 release train.

> We can have both. Also, version macros don't
> multiply the way _HAS_ macros do, over time.

I stumbled on such version macros today by chance.
And pg_config.h seems available on both Windows and Linux.
So I guess that's good enough for conditional compilation.

From the old post I found, and your recent reply Tom,
I got the impression these macros didn't exist. FWIW. --DD

[ddevienne(at)acme include]$ sift VERSION pg*.h
pg_config.h:#define PACKAGE_VERSION "16.1"
pg_config.h:#define PG_MAJORVERSION "16"
pg_config.h:#define PG_MAJORVERSION_NUM 16
pg_config.h:#define PG_MINORVERSION_NUM 1
pg_config.h:#define PG_VERSION "16.1"
pg_config.h:#define PG_VERSION_NUM 160001
pg_config.h:#define PG_VERSION_STR "PostgreSQL 16.1 on
x86_64-pc-linux-gnu, compiled by gcc (GCC) 12.2.1 20221121 (Red Hat
12.2.1-7), 64-bit"