| From: | Srinath Reddy <srinath2133(at)gmail(dot)com> |
|---|---|
| To: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | alvherre(at)alvh(dot)no-ip(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote |
| Date: | 2025-03-29 18:33:10 |
| Message-ID: | CAFC+b6rKQEx3AmOJFJA5hgS2cwYDSWoc+wLh_SPoZJdz5hsF6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
./psql postgres
Hi,
On Fri, Mar 28, 2025 at 5:08 PM Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
wrote:
>
> v04_001* has the changes for CREATE DATABASE/ROLE/USER and
> v04_002* has the changes into pg_upgrade to give ALERTS for invalid names.
>
i have reviewed these patches,in v04_002* i think it would be better if log
all the names like database ,roles/users names then throw error instead of
just logging database names into db_role_invalid_names and throwing
error,which helps the user to see at once all the invalid names and resolve
then again try pg_upgrade,so here i am attaching delta patch for the same
,except this the patches LGTM.
May the force be with you,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/
postgres=# \q
| Attachment | Content-Type | Size |
|---|---|---|
| v05_002-Log-about-all-the-invalid-database-role-user-names-t.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-03-29 18:50:03 | Re: Speed up ICU case conversion by using ucasemap_utf8To*() |
| Previous Message | Andres Freund | 2025-03-29 18:25:15 | Re: AIO v2.5 |