| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect include file order in guc-file.l |
| Date: | 2022-11-03 12:19:07 |
| Message-ID: | CAFBsxsHcg6WM339jmtg8_y2efwG_9eK-BCd1MUMmZet6KcPx0A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 3, 2022 at 6:40 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote:
> > On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud <rjuju123(at)gmail(dot)com>
wrote:
> >> Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch.
> >
> > I've pushed this, thanks!
>
> Thanks for the commit. I've wanted to get it done yesterday but life
> took over faster than that. Before committing the change, there is
> something I have noticed though: this header does not seem to be
> necessary at all and it looks that there is nothing in guc-file.l that
> needs it. Why did you add it in dac048f to begin with?
Because it wouldn't compile otherwise, obviously. :-)
I must have been working on it before bfb9dfd93720
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-11-03 13:06:35 | RE: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Michael Paquier | 2022-11-03 11:58:03 | Re: Commit fest 2022-11 |