Re: pgsql: Build all Flex files standalone

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: John Naylor <john(dot)naylor(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Build all Flex files standalone
Date: 2022-09-04 11:04:13
Message-ID: CAFBsxsGsF+XO_mNoU1QhLB1U70DXbxXPjcyfF4km5ww+Y7e6Vw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Sep 4, 2022 at 4:36 PM John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
>
> For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
> something like the following is needed:
>
> --- a/src/tools/msvc/Mkvcbuild.pm
> +++ b/src/tools/msvc/Mkvcbuild.pm
> @@ -362,6 +362,7 @@ sub mkvcbuild
> $isolation_tester->AddFile('src/test/isolation/specparse.y');
> $isolation_tester->AddFile('src/test/isolation/specscanner.l');
> $isolation_tester->AddFile('src/test/isolation/specparse.c');
> + $isolation_tester->AddFile('src/test/isolation/specscanner.c');
> $isolation_tester->AddIncludeDir('src/test/isolation');

This gets CI green (tip o' the hat to Thomas Munro for off-list advice
on getting that working), so pushed.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2022-09-04 11:38:55 Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Previous Message John Naylor 2022-09-04 11:02:02 pgsql: Fix MSVC linker error for specparse.obj