| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix perltidy breaking perlcritic |
| Date: | 2022-09-13 09:25:18 |
| Message-ID: | CAFBsxsGfpcxgnsJ2CoM+k7uWsMoNXXgqjRmOQBrxGeehw0oFgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Sep 12, 2022 at 4:54 PM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
> > eval "\$hash_ref = $_"; ## no critic (ProhibitStringyEval)
>
> I didn't see this until it got committed, since I'm not subscribed to
> -committers, but I think it would be even better to rely on the fact
> that eval returns the value of the last expression in the string, which
> also gets rid of the ugly quoting and escaping, per the attached.
Hmm, interesting.
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-09-13 09:58:39 | pgsql: Adjust header exceptions for 0bd9c6297 |
| Previous Message | John Naylor | 2022-09-13 09:22:09 | pgsql: Treat Unicode codepoints of category "Format" as non-spacing |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2022-09-13 09:36:43 | Re: proposal: possibility to read dumped table's name from file |
| Previous Message | John Naylor | 2022-09-13 09:22:58 | Re: broken table formatting in psql |