| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use rotate macro in more places |
| Date: | 2022-02-20 06:29:10 |
| Message-ID: | CAFBsxsGOOPwU2hWYSJYKHwYKkwmu9m60cOpzSYA_=8LQykH6MQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 20, 2022 at 1:03 AM Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> I think we can use this macro also in hash_multirange, hash_range,
> and JsonbHashScalarValue as in the attached patch. How about replacing
> them with the macro, too.
Good find. I also found one more in hashfn.c.
On Sat, Feb 19, 2022 at 11:28 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Some comments now look a bit too obvious to keep around, but maybe
> > they should be replaced with a "why", instead of a "what":
>
> Yeah. Maybe like "combine successive hashkeys by rotating"?
Done that way.
Pushed, thank you both for looking!
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2022-02-20 07:35:06 | Re: MultiXact\SLRU buffers configuration |
| Previous Message | Noah Misch | 2022-02-20 04:57:57 | Re: do only critical work during single-user vacuum? |