From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: mark the timestamptz variant of date_bin() as stable |
Date: | 2021-09-20 11:46:59 |
Message-ID: | CAFBsxsFjRQFucp+1LT5PsKbvkixhe1o=ELqRC33eW9LTN9=vcw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Wed, Sep 1, 2021 at 3:25 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> > > On Wed, Sep 1, 2021 at 2:44 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >> I see that these two answers are both exactly multiples of 24 hours
away
> > >> from the given origin. But if I'm binning on the basis of "days" or
> > >> larger units, I would sort of expect to get local midnight, and I'm
not
> > >> getting that once I cross a DST boundary.
> >
> > > Hmm, that's seems like a reasonable expectation. I can get local
midnight
> > > if I recast to timestamp:
> >
> > > # select date_bin('1 day', '2021-11-10 00:00
+00'::timestamptz::timestamp,
> > > '2021-09-01 00:00 -04'::timestamptz::timestamp);
> > > date_bin
> > > ---------------------
> > > 2021-11-09 00:00:00
> > > (1 row)
> >
> > Yeah, and then back to timestamptz if that's what you really need :-(
> >
> > > It's a bit unintuitive, though.
> >
> > Agreed. If we keep it like this, adding some documentation around
> > the point would be a good idea I think.
>
> Attached is a draft doc patch using the above examples. Is there anything
else that would be useful to mention?
Any thoughts on the doc patch?
--
John Naylor
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-09-20 11:48:29 | Re: Coding guidelines for braces + spaces - link 404's |
Previous Message | vignesh C | 2021-09-20 10:50:39 | Re: Added schema level support for publication. |