| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, YANG Xudong <yangxudong(at)ymatrix(dot)cn>, pgsql-hackers(at)lists(dot)postgresql(dot)org, wengyanqing(at)ymatrix(dot)cn, wanghao(at)ymatrix(dot)cn |
| Subject: | Re: [PATCH] Add loongarch native checksum implementation. |
| Date: | 2023-08-10 11:37:24 |
| Message-ID: | CAFBsxsFeDYTf8p+4+3sq4LdxctcFpXJ8Tv9HpAgi_O9AG11AQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote:
> > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am
> > facing the below error:
> > Generating configuration headers...
> > undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line
> > 718 at ../postgresql/src/tools/msvc/Mkvcbuild.pm line 872.
> >
> > Am I missing something or did the commit miss something?
>
> Yes, the commit has missed the addition of USE_LOONGARCH_CRC32C in
> Solution.pm. If you want to be consistent with pg_config.h.in, you
> could add it just after USE_LLVM, for instance.
Oops, fixing now...
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema | 2023-08-10 12:05:44 | Re: proposal: psql: show current user in prompt |
| Previous Message | Thomas Munro | 2023-08-10 10:55:24 | Re: A failure in 031_recovery_conflict.pl on Debian/s390x |