From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
---|---|
To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: double inclusion of '-p' flex flag |
Date: | 2022-04-26 12:25:28 |
Message-ID: | CAFBsxsFH8y29A5Vv476qu8pHtay2BCSsjL3ohzqyujFDRwNi3w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 26, 2022 at 7:16 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>
> Hi,
>
> I see that we have included '-p' flex flag twice in the commands used
> to generate the scanner files. See below:
>
> src/backend/parser/Makefile:60: scan.c: FLEXFLAGS = -CF -p -p
> src/backend/utils/adt/Makefile:122: jsonpath_scan.c: FLEXFLAGS = -CF -p -p
> src/bin/psql/Makefile:61: psqlscanslash.c: FLEXFLAGS = -Cfe -p -p
> src/fe_utils/Makefile:43: psqlscan.c: FLEXFLAGS = -Cfe -p -p
> src/backend/utils/adt/Makefile:122: jsonpath_scan.c: FLEXFLAGS = -CF -p -p
> src/bin/psql/Makefile:61: psqlscanslash.c: FLEXFLAGS = -Cfe -p -p
>
> Do we need this or can the extra -p flag be removed?
From the Flex manual:
"generates a performance report to stderr. The report consists of
comments regarding features of the flex input file which will cause a
serious loss of performance in the resulting scanner. If you give the
flag twice, you will also get comments regarding features that lead to
minor performance losses."
--
John Naylor
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amul Sul | 2022-04-26 12:43:18 | Re: [Patch] ALTER SYSTEM READ ONLY |
Previous Message | Daniel Gustafsson | 2022-04-26 12:21:36 | Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository |