Re: speed up unicode decomposition and recomposition

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>
Subject: Re: speed up unicode decomposition and recomposition
Date: 2020-10-22 09:50:52
Message-ID: CAFBsxsF=Z8qVGj0jKLUK6=qWfrR7OB9zoxpR8NxwgP7y5BsNng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 22, 2020 at 12:34 AM Michael Paquier <michael(at)paquier(dot)xyz>
wrote:

> Thanks for the updated version, that was fast. I have found a couple
> of places that needed to be adjusted, like the comment at the top of
> generate-unicode_norm_table.pl or some comments, an incorrect include
> in the new headers and the indentation was not right in perl (we use
> perltidy v20170521, see the README in src/tools/pgindent).
>
> Except that, this looks good to me. Attached is the updated version
> with all my tweaks, that I would like to commit. If there are any
> comments, please feel free of course.
>

Looks good to me.

--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-10-22 09:54:59 Re: [Patch] Optimize dropping of relation buffers using dlist
Previous Message Thomas Munro 2020-10-22 09:27:00 Re: [Patch] Optimize dropping of relation buffers using dlist