| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Subject: | Re: call popcount32/64 directly on non-x86 platforms |
| Date: | 2021-08-16 15:56:17 |
| Message-ID: | CAFBsxsEwytjytnNpN_bfF2jSYdy3ADdvpZe=7eLHvagFfjevPg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> On Thu, Aug 12, 2021 at 1:26 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > Closer, but I don't see why there's any need to make the fast and slow
> > functions external. It should be perfectly fine to keep them static.
> >
> > I didn't test the performance, but the attached works for me.
>
> Thanks for that! I still get a big improvement to on Power8 / gcc 4.8,
but it's not quite as fast as earlier versions, which were around 200ms:
>
> master: 646ms
> v3: 312ms
>
> This machine does seem to be pickier about code layout than any other
I've tried running benchmarks on, but that's still a bit much. In any case,
your version is clearer and has the intended effect, so I plan to commit
that, barring other comments.
Pushed, thanks for looking1
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-08-16 15:57:12 | Re: Window Function "Run Conditions" |
| Previous Message | Álvaro Herrera | 2021-08-16 15:46:16 | Re: Autovacuum on partitioned table (autoanalyze) |