Re: pgsql: Build all Flex files standalone

On Tue, Sep 6, 2022 at 11:49 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> crake is still unhappy:
>
> Sep 06 00:09:55 In file included from /tmp/headerscheck.AwLxya/test.c:2:
> Sep 06 00:09:55 /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: fatal error: jsonpath_gram.h: No such file or directory
> Sep 06 00:09:55 26 | #include "jsonpath_gram.h"
> Sep 06 00:09:55 | ^~~~~~~~~~~~~~~~~
>
> I wonder if that file is not getting installed in a directory that
> this test expects to search.

There are two proposed fixes upthread, which I will copy below, but if
I can't reproduce locally, I don't have much confidence in which one
is the way to go to get crake green again:

Andrew:

> Probably happens because crake does vpath builds. I think you're going
> to have to set up EXTRAINCLUDES for it - see near the bottom of the
> headerscheck script. Possibly something like
>
>
> src/backend/utils/adt/*)
>
> EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;

Andres:

> It doesn't happen for gramparse.h because gram.h is copied to
> src/include/parser (see src/backend/Makefile), and included as parser/gram.h.
>
> I think this could be addressed by always adding something like
> -iquote $builddir/$(dirname "$f") -iquote $srcdir/$(dirname "$f") \
> to cpluspluscheck/headerscheck.

--
John Naylor
EDB: http://www.enterprisedb.com