From: | Yeb Havinga <yebhavinga(at)gmail(dot)com> |
---|---|
To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parameterized aggregate subquery (was: Pull up aggregate subquery) |
Date: | 2011-07-05 11:15:44 |
Message-ID: | CAF8rK4RrsKeMzgfP+vWNcyuPoN=SJ-3pZnG48zSGeyFkLhJGRg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Hitosh, list,
>
> > Attached is revised version.
>
> I failed to attached the patch. I'm trying again.
>
> I'm currently unable to test, since on holiday. I'm happy to continue
testing once returned but it may not be within the bounds of the current
commitfest, sorry.
> >> 5) Regression tests are missing; I think at this point they'd aid in
> >> speeding up development/test cycles.
> >
> > I'm still thinking about it. I can add complex test but the concept of
> > regression test focuses on small pieces of simple cases. I don't want
> > take pg_regress much more than before.
>
IMHO, at least one query where the new code is touched is a good idea.
>> I get the same error with the version from june 9 with current git HEAD.
> >
> > Fixed. Some variable initializing was wrong.
>
Thanks - will test when I am back from holiday and other duties.
regards,
Yeb
From | Date | Subject | |
---|---|---|---|
Next Message | Hitoshi Harada | 2011-07-05 11:43:46 | Re: Parameterized aggregate subquery (was: Pull up aggregate subquery) |
Previous Message | Simon Riggs | 2011-07-05 11:08:11 | Re: Cascade replication |