Re: [PATCH] big test separation POC

From: Samrat Revagade <revagade(dot)samrat(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] big test separation POC
Date: 2013-07-01 14:28:19
Message-ID: CAF8Q-Gx=CR46wvrbBCB-AbFP2cExSs3bvH3u0LLWxBUWkovOGg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fabien,

On Mon, Jul 1, 2013 at 10:42 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:

>
> - I do not understand why the makefile specifies $(srcdir) before
>>> local files in some places.
>>>
>>
>> For VPATH builds :-)
>>
>
> Here is a v2 which is more likely to work under VPATH.

I really appreciate your efforts. I am reviewing your patch.

While testing patch, I found that make installcheck breaks with your patch
and gives following error:

============== running regression test queries ==============
pg_regress: could not open file "./serial_schedule" for reading: No such
file or directory

looks like you forgot to add entry for serial_schedule.

Following sequence of commands will reproduces this error:
1) ./configure
2) make
3) make install
4) initialize the database cluster (initdb)
5) start the server
6) make installcheck

I will post more review comments if there are any.

--
Regards,

Samrat Revgade

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-07-01 14:36:37 Re: New regression test time
Previous Message David Fetter 2013-07-01 14:20:22 Re: Documentation/help for materialized and recursive views