From: | Oleg Bartunov <obartunov(at)gmail(dot)com> |
---|---|
To: | Josh Berkus <josh(at)agliodbs(dot)com> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: jsonb and nested hstore |
Date: | 2014-02-05 07:21:25 |
Message-ID: | CAF4Au4y3Qa-27cxyHYzmeBJSKLO+6OGwN_6Z0mKJaH+PjE+PAw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew provided us more information and we'll work on recv. What
people think about testing this stuff ? btw, we don't have any
regression test on this.
Oleg
On Wed, Feb 5, 2014 at 2:03 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> On 02/03/2014 07:27 AM, Andres Freund wrote:
>> On 2014-02-03 09:22:52 -0600, Merlin Moncure wrote:
>>>> I lost my stomach (or maybe it was the glass of red) somewhere in the
>>>> middle, but I think this needs a lot of work. Especially the io code
>>>> doesn't seem ready to me. I'd consider ripping out the send/recv code
>>>> for 9.4, that seems the biggest can of worms. It will still be usable
>>>> without.
>>>
>>> Not having type send/recv functions is somewhat dangerous; it can
>>> cause problems for libraries that run everything through the binary
>>> wire format. I'd give jsonb a pass on that, being a new type, but
>>> would be concerned if hstore had that ability revoked.
>>
>> Yea, removing it for hstore would be a compat problem...
>>
>>> offhand note: hstore_send seems pretty simply written and clean; it's
>>> a simple nonrecursive iterator...
>>
>> But a send function is pretty pointless without the corresponding recv
>> function... And imo recv simply is to dangerous as it's currently
>> written.
>> I am not saying that it cannot be made work, just that it's still nearly
>> as ugly as when I pointed out several of the dangers some weeks back.
>
> Oleg, Teodor, any comments on the above?
>
> --
> Josh Berkus
> PostgreSQL Experts Inc.
> http://pgexperts.com
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-02-05 07:56:42 | Re: Failure while inserting parent tuple to B-tree is not fun |
Previous Message | Michael Paquier | 2014-02-05 07:03:51 | Re: PostgreSQL Failback without rebuild |