From: | Jing Wang <jingwangian(at)gmail(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
Subject: | Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE |
Date: | 2018-01-20 08:06:46 |
Message-ID: | CAF3+xM+PwZ7bF4p8rYwE=0jdXPMkO4ex8n10UZET1JZrpREREw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Stephen and Thomas,
Thanks your review comments.
Enclosed please find the latest patch.
>/src/backend/parser/gram.y: In function ‘base_yyparse’:
>/src/backend/parser/gram.y:1160:19: warning: assignment from incompatible
pointer type [-Wincompatible-pointer-types]
>| IN_P DATABASE db_spec_name { $$ = $3; }
The warning has been dismissed.
>When it should be:
>ALTER DATABASE { <replaceable class="parameter">name</replaceable> |
CURRENT_DATABASE } OWNER TO { <replaceable>new_owner</replaceable> |
CURRENT_USER | SESSION_USER }
Yes. It should be.
>Please don't include whitespace-only hunks, like this one:
Ok.
>The TAP regression tests for pg_dump are failing.
The test case has been updated.
>make makeDbSpec() return a DbSpec and then try to minimize the
>forced-casting happening.
Makes sense. It has been changed.
Regards,
Jing Wang
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
support_CURRENT_DATABASE_keyword_v4.6.patch | application/octet-stream | 58.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-01-20 10:14:54 | Re: [Sender Address Forgery]Re: pg_(total_)relation_size and partitioned tables |
Previous Message | Amit Kapila | 2018-01-20 06:01:20 | Re: Test-cases for exclusion constraints is missing in alter_table.sql file |