From: | Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_upgrade --check fails to warn about abstime |
Date: | 2023-09-27 05:40:53 |
Message-ID: | CAF1DzPXajShJe0qy0=gLjCPh_UA=JqPrJgrUae5TV+Dr8ZzS_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 22, 2023 at 4:44 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:
> On 2023-Sep-21, Tom Lane wrote:
>
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
>
> > > Wow, I never added code to pg_upgrade to check for that, and no one
> > > complained either.
> >
> > Yeah, so most people had indeed listened to warnings and moved away
> > from those datatypes. I'm inclined to think that adding code for this
> > at this point is a bit of a waste of time.
>
> The migrations from versions prior to 12 have not stopped yet, and I did
> receive a complaint about it. Because the change is so simple, I'm
> inclined to patch it anyway, late though it is.
>
> I decided to follow Tristan's advice to add the version number as a
> parameter to the new function; this way, the knowledge of where was what
> dropped is all in the callsite and none in the function. It
> looked a bit schizoid otherwise.
>
yeah, looks good to me.
>
> --
> Álvaro Herrera 48°01'N 7°57'E —
> https://www.EnterpriseDB.com/
> "Postgres is bloatware by design: it was built to house
> PhD theses." (Joey Hellerstein, SIGMOD annual conference 2002)
>
--
--
Thanks & Regards,
Suraj kharage,
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-09-27 05:43:42 | Re: Invalidate the subscription worker in cases where a user loses their superuser status |
Previous Message | Amit Kapila | 2023-09-27 05:21:52 | Re: Move global variables of pgoutput to plugin private scope. |