| From: | Simon Muller <samullers(at)gmail(dot)com> |
|---|---|
| To: | Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow COPY's 'text' format to output a header |
| Date: | 2018-08-02 19:30:26 |
| Message-ID: | CAF1-J-0adWePZkETpea1PEtdGChT5yu0AegPgOnNNdQsnx1g3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2 August 2018 at 17:07, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>
wrote:
>
> > On Aug 2, 2018, at 8:11 AM, Daniel Verite <daniel(at)manitou-mail(dot)org>
> wrote:
> >
> > That makes sense, thanks for elaborating, although there are also
> > a fair number of ERRCODE_FEATURE_NOT_SUPPORTED in copy.c
> > that are raised on forbidden/nonsensical combination of features,
> > so the consistency argument could work both ways.
> >
>
> If there is not a strong reason to change the error code, then I believe
> we should not. The error is the same as it was before, just narrower in
> scope.
>
> Best,
> -Cynthia
Sure, thanks both for the feedback. Attached is a patch with the error kept
as ERRCODE_FEATURE_NOT_SUPPORTED.
--
Simon Muller
| Attachment | Content-Type | Size |
|---|---|---|
| text_header_v5.patch | application/octet-stream | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-08-02 19:30:46 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |
| Previous Message | Robert Haas | 2018-08-02 19:19:49 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |