Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

From: Amol Vyavahare <amol(dot)vyavahare(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.
Date: 2020-04-15 08:56:19
Message-ID: CAF0fJeU0bWMvzxm+Amj4iJTRj_=a5Q5WFLPtkEEpKhdMr1VEAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Sure, will do that.

On Wed, Apr 15, 2020 at 1:33 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Amol,
>
> On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> I am reviewing this patch.
>>
>> Thanks,
>> Khushboo
>>
>> On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare <
>> amol(dot)vyavahare(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>> Attached is the patch to fix the Issue with temporary tables on commit
>>> drop as. This patch fixes the issue where an error was thrown when the user
>>> tried to create a temporary table via query tool and no result
>>> was displayed when the query was executed.
>>>
>>> Please review.
>>>
>>> Please write the API test cases for the same even if the changes are
> very small but they are in the SQL Editor backend code.
> The patch is working fine and looks good to me.
>
> Thanks,
> Khushboo
>
>> --
>>> *Regards,*
>>> *Amol Vyavahare*
>>> *E**nterpriseDB Corporation*
>>> The Enterprise Postgres Company
>>> *T: +91 20 6644 9600, M: +91 738 738 2128*
>>> [image: EDB Postgres] <http://www.edbpostgres.com/>Unit 301 A, Third
>>> Floor, Godrej Castlemaine,
>>> 155, Sassoon Road, Pune, MH - 411001
>>> [image: Blog Feed] <http://blogs.edbpostgres.com/> [image: Facebook]
>>> <https://www.facebook.com/EnterpriseDB> [image: Twitter]
>>> <https://twitter.com/EnterpriseDB> [image: LinkedIn]
>>> <https://www.linkedin.com/company/14958?trk=tyah> [image: Google+]
>>> <https://plus.google.com/108046988421677398468>
>>> Website: www.enterprisedb.com
>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/
>>> Follow us on Twitter: http://www.twitter.com/enterprisedb
>>>
>>>
>>>
>>>

--
*Regards,*
*Amol Vyavahare*
*E**nterpriseDB Corporation*
The Enterprise Postgres Company
*T: +91 20 6644 9600, M: +91 738 738 2128*
[image: EDB Postgres] <http://www.edbpostgres.com/>Unit 301 A, Third Floor,
Godrej Castlemaine,
155, Sassoon Road, Pune, MH - 411001
[image: Blog Feed] <http://blogs.edbpostgres.com/> [image: Facebook]
<https://www.facebook.com/EnterpriseDB> [image: Twitter]
<https://twitter.com/EnterpriseDB> [image: LinkedIn]
<https://www.linkedin.com/company/14958?trk=tyah> [image: Google+]
<https://plus.google.com/108046988421677398468>
Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message navnath gadakh 2020-04-15 09:17:50 Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size
Previous Message Akshay Joshi 2020-04-15 08:28:56 Re: [pgAdmin4 - Bug #5387]