Re: Removing Functionally Dependent GROUP BY Columns

From: Geoff Winkless <pgsqladmin(at)geoff(dot)dj>
To: Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removing Functionally Dependent GROUP BY Columns
Date: 2016-01-14 13:29:10
Message-ID: CAEzk6ffcFj2RwTbE35iTyArkY7k_ZHBi-DTV0_moT5qiCMBQTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14 January 2016 at 13:16, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> wrote:
> You're absolutely right, but in this case the comment is more like a
> reminder of a bigger comment few lines before that wasn't quoted in my mail

Fair enough, although I have two niggles with that:

a) the second comment could become physically separated from the first
by later additions of extra code, or by refactoring;
b) if you don't need the comment because the explanation for it is
local anyway and the comment tells you nothing that the code doesn't,
why have it at all?

> so I assume it's ok to keep it this way.

Of course it's ok to do whatever you decide is best: as I said
previously, I fully appreciate that I have no ownership over any of
the code.

Geoff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Filip Rembiałkowski 2016-01-14 13:40:13 tiny doc patch
Previous Message Julien Rouhaud 2016-01-14 13:16:05 Re: Removing Functionally Dependent GROUP BY Columns