| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade |
| Date: | 2024-06-19 13:07:42 |
| Message-ID: | CAEze2WjrAvyhwBh=rS+3DK2gpoXNOV-=5YB3APkV=Q3cOtMkVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 14 Jun 2024 at 23:29, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Wed, Jun 12, 2024 at 09:41:01AM -0500, Nathan Bossart wrote:
> > Actually, I think you are right that we need a manual checkpoint, except I
> > think we need it to be after prepare_new_globals(). set_frozenxids()
> > connects to each database (including template0) and updates a bunch of
> > pg_class rows, and we probably want those on disk before we start copying
> > the files to create all the user's databases.
Good catch, I hadn't thought of that.
> Here is an updated patch.
LGTM.
Kind regards,
Matthias van de Meent
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-06-19 13:17:00 | Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade |
| Previous Message | Ranier Vilela | 2024-06-19 12:59:23 | Re: Add pg_get_acl() function get the ACL for a database object |