Re: pg_dump --no-comments confusion

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --no-comments confusion
Date: 2024-11-04 15:13:25
Message-ID: CAEze2WjeKRc2H9-Y7-csVHpbhTsaBWMavJJP3aWbjbXJkyWTjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 4 Nov 2024 at 15:41, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> Someone emailed me privately saying they were confused because they
> thought pg_dump --no-comments would remove SQL comments, not the SQL
> COMMENT commands. Is this something worth clarifying in our docs? I am
> not even sure how I would express it. It currently says:
>
> --no-comments
> Do not dump comments.
>
> We could change it to:
>
> --no-comments
> Do not dump SQL COMMENT commands

I think that'd be more confusing, as SQL comments are /* */. There is
no SQL standard-prescribed COMMENT command (if our current docs are to
be believed, I don't have a recent version of ISO 9075 to verify that
claim).

Maybe: "Do not dump database object comments", or "Do not dump COMMENT
ON ... -commands"?

Kind regards,

Matthias van de Meent
Neon (https://neon.tech/)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-11-04 15:16:25 Re: Pgoutput not capturing the generated columns
Previous Message vignesh C 2024-11-04 15:11:55 Re: Pgoutput not capturing the generated columns