Re: src/include/miscadmin.h outdated comments

On Fri, 1 Mar 2024 at 12:19, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> /*****************************************************************************
> * globals.h -- *
> *****************************************************************************/
>
> The above comment src/include/miscadmin.h is not accurate?
> we don't have globals.h file?

The header of the file describes the following:

* miscadmin.h
* This file contains general postgres administration and initialization
* stuff that used to be spread out between the following files:
* globals.h global variables
* pdir.h directory path crud
* pinit.h postgres initialization
* pmod.h processing modes
* Over time, this has also become the preferred place for widely known
* resource-limitation stuff, such as work_mem and check_stack_depth().

So, presumably that section is what once was globals.h.

As to whether the comment should remain now that it's been 17 years
since those files were merged, I'm not sure: while the comment has
mostly historic value, there is something to be said about it
delineating sections of the file.

Kind regards,

Matthias van de Meent
Neon (https://neon.tech)