| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
| Date: | 2022-06-16 09:17:01 |
| Message-ID: | CAEze2WiqY3b_FKSUGV8mDMMu+Neb37aCsvMUvKoYJmfNCs+pqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 15 Jun 2022 at 16:51, Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
>
> Hi hackers,
>
> I noticed that cfbot is not entirely happy with the patch, so I rebased it.
>
> > I see that COMPRESSION and STORAGE now are handled slightly
> > differently in the grammar. Maybe we could standardize that a bit
> > more; so that we have only one `STORAGE [kind]` definition in the
> > grammar?
> >
> > As I'm new to the grammar files; would you know the difference between
> > `name` and `ColId`, and why you would change from one to the other in
> > ALTER COLUMN STORAGE?
>
> Good point, Matthias. I addressed this in 0002. Does it look better now?
When updating a patchset generally we try to keep the patches
self-contained, and update patches as opposed to adding incremental
patches to the set.
Apart from this comment on the format of the patch, the result seems solid.
- Matthias
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-06-16 09:22:15 | PGDOCS - Integer configuration parameters should say "(integer)" |
| Previous Message | Kirill Reshke | 2022-06-16 08:41:21 | Re: Extensible storage manager API - smgr hooks |