Re: Improvements and additions to COPY progress reporting

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improvements and additions to COPY progress reporting
Date: 2021-03-04 16:19:18
Message-ID: CAEze2WiT=nZYmegVmK=MK6yOxf-h+zV7S-9C0soLdiKX_-WQtg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 4 Mar 2021 at 13:36, Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> + <para>
> + Each backend running <command>VACUUM</command> without the
> + <literal>FULL</literal> option will report its progress in the
> + <structname>pg_stat_progress_vacuum</structname> view. Backends running
> + <command>VACUUM</command> with the <literal>FULL</literal> option report
> + progress in the <structname>pg_stat_progress_cluster</structname> view
> + instead. See <xref linkend="vacuum-progress-reporting"/> and
> + <xref linkend="cluster-progress-reporting"/> for details.
> + </para>
>
> I think a typo, missing "will" between option and report - it's "with
> the <literal>FULL</literal> option will report"

"Backends running [...] report progress to [...] instead" is,
a.f.a.i.k., correct English. Adding 'will' would indeed still be
correct, but it would in my opinion also be decremental to the
readability of the section due to the repeated use of the same
template sentence structure. I think that keeping it as-is is just
fine.

With regards,

Matthias van de Meent.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2021-03-04 16:22:48 Re: WIP: document the hook system
Previous Message Tom Lane 2021-03-04 16:11:39 Re: Removing support for COPY FROM STDIN in protocol version 2