| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Michel Pelletier <pelletier(dot)michel(at)gmail(dot)com> |
| Subject: | Re: Reducing output size of nodeToString |
| Date: | 2024-03-20 12:03:39 |
| Message-ID: | CAEze2WherjTZXLfg2x=MLAqDzbd9wUk_CqSc7PMmNWo1ut88fQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 20 Mar 2024 at 12:49, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 19.03.24 17:13, Peter Eisentraut wrote:
> > On 11.03.24 21:52, Matthias van de Meent wrote:
> >>> * v7-0003-gen_node_support.pl-Mark-location-fields-as-type-.patch
> >>>
> >>> This looks sensible, but maybe making Location a global type is a bit
> >>> much? Maybe something more specific like ParseLocation, or ParseLoc, to
> >>> keep it under 12 characters.
> >> I've gone with ParseLoc in the attached v8 patchset.
> >
> > I have committed this one.
>
> Next, I was looking at
> v8-0003-pg_node_tree-Don-t-store-query-text-locations-in-.patch.
[...]
> So anyway, my idea was that we should turn this around and make
> nodeToString() always drop location information, and instead add
> nodeToStringWithLocations() for the few debugging uses. And this would
> also be nice because then it matches exactly with the existing
> stringToNodeWithLocations().
That seems reasonable, yes.
-Matthias
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-03-20 12:53:52 | Re: remaining sql/json patches |
| Previous Message | Ashutosh Bapat | 2024-03-20 11:52:47 | Re: DOCS: add helpful partitioning links |