Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)
Date: 2021-04-06 12:39:54
Message-ID: CAEze2WgjXRVij+romZS-Q50eSoZz1R4e6eZ=njJu-G9DTn+=GQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 6 Apr 2021 at 14:29, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> Thanks! So I applied all the changes that I suggested upthread to the patch.
> I also updated the comment as follows.
>
> * Import table data for partitions only when they are explicitly
> - * specified in LIMIT TO clause. Otherwise ignore them and
> - * only include the definitions of the root partitioned tables to
> - * allow access to the complete remote data set locally in
> - * the schema imported.
> + * specified in LIMIT TO clause. Otherwise ignore them and only
> + * include the definitions of the root partitioned tables to allow
> + * access to the complete remote data set locally in the schema
> + * imported.
>
> Attached is the updated version of the patch. Barring any objection,
> I'm thinking to commit this.

Thanks, this was on my to-do list for today, but you were faster.

No objections on my part, and thanks for picking this up.

With regards,

Matthias van de Meent

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-04-06 13:02:22 Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)
Previous Message Michael Paquier 2021-04-06 12:39:53 Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?