Re: [PATCH] Add GitLab CI to PostgreSQL

On Wed, 5 Jul 2023 at 15:22, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 2023-07-04 Tu 19:44, Newhouse, Robin wrote:
>
> > Hello!
> >
> > I propose the attached patch to be applied on the 'master' branch
> > of PostgreSQL to add GitLab CI automation alongside Cirrus CI in the PostgreSQL repository.

Can you configure GitLab to use a .gitlab-ci.yml file that is not in
the root directory?

> > It is not intended to be a replacement for Cirrus CI, but simply suggestion for the
> > PostgreSQL project to host centrally a Gitlab CI definition for those who prefer to use
> > it while developing/testing PostgreSQL.
> >
> > The intent is to facilitate collaboration among GitLab users, promote standardization
> > and consistency, and ultimately, improve testing and code quality.
> >
> This seems very RedHat-centric, which I'm not sure is a good idea. Also, shouldn't at least some of these recipes call dnf and dnf-builddep instead of yum and yum-build-dep?

I don't think it's bad to add an automated test suite for redhat-based images?

> If we're going to do this then arguably we should also be supporting GitHub Actions and who knows what other CI frameworks. There is a case for us special casing Cirrus CI because it's used for the cfbot.

I think there's a good case for _not_ using Cirrus CI, namely that the
license may be prohibitive, self-management of the build system
(storage of artifacts, UI, database) is missing for Cirrus CI, and it
also seems to be unable to run automated CI on repositories that
aren't hosted on Github.
I think these are good arguments for adding a GitLab CI configuration.

Unless the cfbot is entirely under management of the PostgreSQL
project (which it doesn't appear to be, as far as I know the URL is
still cfbot.cputube.org indicating some amount of external control)
the only special casing for Cirrus CI within the project seems to be
"people have experience with this tool", which is good, but not
exclusive to Cirrus CI - clearly there are also people here who have
experience with (or are interested in) maintaining GitLab CI
configurations.

Kind regards,

Matthias van de Meent
Neon (https://neon.tech)