| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Alexandra Wang <lewang(at)pivotal(dot)io> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com> |
| Subject: | Re: Report error position in partition bound check |
| Date: | 2020-04-09 13:51:15 |
| Message-ID: | CAExHW5vXBd39SuU283bCabBsCTHBKbfJ2mxRqiu8JpM2iFFLjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alexandra,
As Michael said it will be considered for the next commitfest. But
from a quick glance, a suggestion.
Instead of passing NULL parsestate from ATExecAttachPartition, pass
make_parsestate(NULL). parse_errorposition() takes care of NULL parse
state input, but it might be safer this way. Better if we could cook
up a parse state with the query text available in
AlterTableUtilityContext available in ATExecCmd().
On Thu, Apr 9, 2020 at 6:36 AM Alexandra Wang <lewang(at)pivotal(dot)io> wrote:
>
> Forgot to run make installcheck. Here's the new version of the patch that updated the test answer file.
>
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-04-09 14:00:52 | Re: Vacuum o/p with (full 1, parallel 0) option throwing an error |
| Previous Message | Tom Lane | 2020-04-09 13:46:38 | Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables |