From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Error in StrategySyncStart() prologue |
Date: | 2025-01-31 04:14:29 |
Message-ID: | CAExHW5uzZhmbYL+nfomqmOj7BOMw1ZZO8HZkQojidgY-erDw5g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 31, 2025 at 7:38 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jan 30, 2025 at 05:36:32PM +0900, Michael Paquier wrote:
> > Indeed, your suggestion sounds right. StrategySyncStart() is only
> > used in BgBufferSync() for the background writer since 9cd00c457e6a,
> > and this commit seems to have missed the comment update.
>
> And done.
> --
> Michael
Thanks a lot.
Your archaeology investigation is correct. I looked through the
changes to the names and signatures of BufferSync and BgBufferSync but
most of them were more than a decade ago. So I was doubtful about this
error being so far in the history. I traced the changes to the
function body but not as far as 8 years back.
--
Best Wishes,
Ashutosh Bapat
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2025-01-31 04:37:03 | Re: [PATCH] Optionally record Plan IDs to track plan changes for a query |
Previous Message | jian he | 2025-01-31 03:52:42 | Re: Non-text mode for pg_dumpall |