| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Test to dump and restore objects left behind by regression |
| Date: | 2025-04-01 07:43:07 |
| Message-ID: | CAExHW5uaT8j1DQSyeGG6VC78sSL2oqBO89wStEhWqjE05j=L_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 1, 2025 at 11:52 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2025-Mar-31, Daniel Gustafsson wrote:
>
> > Given where we are in the cycle, it seems to make sense to stick to using the
> > schedule we already have rather than invent a new process for generating it,
> > and work on that for 19?
>
> No objections to that. I'll see about getting this committed during my
> morning today, so that I have plenty of time to watch the buildfarm.
Thanks Alvaro.
Just today morning, I found something which looks like another bug in
statistics dump/restore [1]. As Daniel has expressed upthread [2], we
should go ahead and commit the test even if the bug is not fixed. But
in case it creates a lot of noise and makes the build farm red, we
could suppress the failure by not dumping statistics for comparison
till the bug is fixed. PFA patchset which reintroduces 0003 which
suppresses the statistics dump - in case we think it's needed. I have
made some minor cosmetic changes to 0001 and 0002 as well.
I will also watch buildfarm too, once you commit the patch.
--
Best Wishes,
Ashutosh Bapat
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Use-only-one-format-and-make-the-test-run-d-20250401.patch | text/x-patch | 5.4 KB |
| 0001-Test-pg_dump-restore-of-regression-objects-20250401.patch | text/x-patch | 16.5 KB |
| 0003-Do-not-dump-statistics-in-the-file-dumped-f-20250401.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rahila Syed | 2025-04-01 07:43:21 | Re: Improve monitoring of shared memory allocations |
| Previous Message | Ashutosh Bapat | 2025-04-01 07:24:13 | statistics import and export: another difference in dump/restore |