Error in StrategySyncStart() prologue

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Error in StrategySyncStart() prologue
Date: 2025-01-30 05:34:19
Message-ID: CAExHW5tgkjag8i-s=RFrCn5KAWDrC4zEPPkfUKczfccPOxBRQQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
The prologue of StrategySyncStart() mentions BufferSync(), but the
latter function does not call the first function. Instead
StrategySyncStart() is called by BgBufferSync() which uses the buffer
id provided by the first function to decide the buffer from where to
start syncing as mentioned in the first function's prologue.
BufferSync, on the other hand, scans all the buffers and does not use
the output of StrategySyncStart(). I think the prologue of
StrategySyncStart() intends to refer to BgBufferSync() and not
BufferSync(). PFA patch fixing the prologue.

--
Best Wishes,
Ashutosh Bapat

Attachment Content-Type Size
0001-Fix-StrategySyncStart-prologue-20250130.patch text/x-patch 1.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nisha Moond 2025-01-30 06:30:02 Re: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots
Previous Message Peter Smith 2025-01-30 05:31:40 Re: Skip collecting decoded changes of already-aborted transactions