Re: Postgres Partitions Limitations (5.11.2.3)

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: navbarry(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Postgres Partitions Limitations (5.11.2.3)
Date: 2023-12-05 14:57:18
Message-ID: CAExHW5t8zt8sr4rXc99zpDN-pR3=o8-CsLWOzCG+VM054NsYAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Tue, Dec 5, 2023 at 1:40 AM Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> wrote:
>
> On Fri, 2023-12-01 at 18:49 +0530, Ashutosh Bapat wrote:
> > On Thu, Nov 30, 2023 at 10:29 PM Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> wrote:
> > >
> > > On Thu, 2023-11-30 at 19:22 +0530, Ashutosh Bapat wrote:
> > > > May be attach the patch to hackers thread (this) as well?
> > >
> > > If you want, sure. I thought it was good enough if the thread
> > > is accessible via the commitfest app.
> >
> > The addition is long enough that it deserved to be outside of parentheses.
> >
> > I think it's worth mentioning the exception but in a way that avoids
> > repeating what's mentioned in the last paragraph of just the previous
> > section. I don't have brilliant ideas about how to rephrase it.
> >
> > Maybe "Using ONLY to add or drop a constraint, other than PRIMARY and
> > UNIQUE, on only the partitioned table is supported as long as there
> > are no partitions. ...".
>
> I agree that the parenthesis is too long. I shortened it in the attached
> patch. Is that acceptable?

It's still longer than the actual sentence :). I am fine with it if
somebody else finds it acceptable.

--
Best Wishes,
Ashutosh Bapat

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2023-12-07 19:18:28 Re: [DOCS] Add example about date ISO format
Previous Message David G. Johnston 2023-12-04 20:46:00 Re: Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2023-12-05 15:34:52 Re: introduce dynamic shared memory registry
Previous Message Andrew Dunstan 2023-12-05 14:56:03 Re: Emitting JSON to file using COPY TO