| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-03-25 11:25:27 |
| Message-ID: | CAExHW5srv7sqTrjC4UAOyHqS6XNDFjC9VPj7mbNq8Qt1qtL0Cw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 25, 2025 at 3:22 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shubham,
>
> > The attached patches contain the suggested changes.
>
> Thanks for updating the patch. I reviewed only 0001 because they would be committed separately.
> Few comments:
>
> 01.
> ```
> + For every non-template database on the source server, create one
> + subscription on the target server in the database with the same name.
> ```
>
> It is quite confusing for me; We do not have to describe users that this command
> checks databases of the source server. How about something like:
> "Create one subscription per all non-template databases on the target server."
>
The new description doesn't mention the link between the source and
target database. And I think it's incorrect. Not all databases on the
target server will receive a subscription. Only those which have the
same name as a database on the source server. Am I correct? I prefer
the previous wording, even if it's a bit complex, over a simpler but
incorrect description.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-03-25 11:34:21 | Re: Fix 035_standby_logical_decoding.pl race conditions |
| Previous Message | Aleksander Alekseev | 2025-03-25 11:17:39 | [PATCH] Split varlena.c into varlena.c and bytea.c |