From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
---|---|
To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: define PG_REPLSLOT_DIR |
Date: | 2024-08-21 04:44:20 |
Message-ID: | CAExHW5sftQB-2LNBRX_G2X=7JmDLmoPQyAZb38_T1D2jUov6bQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
If this isn't in commitfest already, please add it there.
On Tue, Aug 20, 2024 at 9:58 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Tue, Aug 20, 2024 at 12:06:52PM +0000, Bertrand Drouvot wrote:
> > Hi,
> >
> > On Tue, Aug 20, 2024 at 05:41:48PM +0900, Michael Paquier wrote:
> > > On Tue, Aug 20, 2024 at 11:10:46AM +0530, Ashutosh Bapat wrote:
> > > > Since these are all related changes, doing them at once might make it
> > > > faster. You may use multiple commits (one for each change)
> > >
> > > Doing multiple commits with individual definitions for each path would
> > > be the way to go for me. All that is mechanical, still that feels
> > > slightly cleaner.
> >
> > Right, that's what v2 has done. If there is a need for v3 then I'll add one
> > dedicated patch for Ashutosh's proposal in the v3 series.
>
> Ashutosh's idea is implemented in v3 that I just shared up-thread (I used
> REPLSLOT_DIR_ARGS though).
>
> Regards,
>
> --
> Bertrand Drouvot
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com
--
Best Wishes,
Ashutosh Bapat
From | Date | Subject | |
---|---|---|---|
Next Message | Bertrand Drouvot | 2024-08-21 05:03:57 | Re: define PG_REPLSLOT_DIR |
Previous Message | Amit Kapila | 2024-08-21 04:29:06 | Re: Fix memory counter update in reorderbuffer |