| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: PG_TEST_EXTRA and meson |
| Date: | 2024-08-29 10:33:45 |
| Message-ID: | CAExHW5sVv1vMo0Nm2FxK7gwJSyARk7vox1DaO40UKMw8qqotRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 28, 2024 at 8:46 PM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> Also, I think TEST 110 and 170 do not look correct to me. In the
> current way, we do not pass PG_TEST_EXTRA to the make command.
>
> 110 should be:
> 'cd $XID_MODULE_DIR && PG_TEST_EXTRA=xid_wraparound make check'
> instead of 'PG_TEST_EXTRA=xid_wraparound cd $XID_MODULE_DIR && make
> check'
>
> 170 should be:
> 'cd $XID_MODULE_DIR && PG_TEST_EXTRA="" make check && cd $PGDir'
> instead of 'PG_TEST_EXTRA="" cd $XID_MODULE_DIR && make check && cd
> $PGDir'
>
You are right. Jacob did point that out, but I didn't fix all the
places back then. Here's updated script.
--
Best Wishes,
Ashutosh Bapat
| Attachment | Content-Type | Size |
|---|---|---|
| test_pg_test_extra.sh | application/x-shellscript | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-08-29 11:12:50 | Re: Conflict Detection and Resolution |
| Previous Message | Bertrand Drouvot | 2024-08-29 10:14:04 | Re: Add contrib/pg_logicalsnapinspect |