| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Test to dump and restore objects left behind by regression |
| Date: | 2024-02-23 05:03:42 |
| Message-ID: | CAExHW5sOTxH8_pUHQeZUr=OoH8tyGw1v=c-kTLJPxg-jdzQSZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 22, 2024 at 3:50 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 22.02.24 11:00, Daniel Gustafsson wrote:
> >> On 22 Feb 2024, at 10:55, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >> On Thu, Feb 22, 2024 at 3:03 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> >> Somebody looking for dump/restore tests wouldn't search
> >> src/bin/pg_upgrade, I think.
> >
> > Quite possibly not, but pg_upgrade is already today an important testsuite for
> > testing pg_dump in binary-upgrade mode so maybe more developers touching
> > pg_dump should?
>
> Yeah, I think attaching this to the existing pg_upgrade test would be a
> good idea. Not only would it save test run time, it would probably also
> reduce code duplication.
>
That's more than one vote for adding the test to 002_pg_ugprade.pl.
Seems fine to me.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-02-23 05:16:01 | Re: Test to dump and restore objects left behind by regression |
| Previous Message | Robert Haas | 2024-02-23 04:52:32 | Re: RFC: Logging plan of the running query |