| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c) |
| Date: | 2021-06-28 11:08:54 |
| Message-ID: | CAEudQArxzUpB4rA2JvgVV5DVhXAmQGjw6xU83n69ki8gMBLk0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em seg., 28 de jun. de 2021 às 00:29, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:
> On Mon, Jun 28, 2021 at 10:17:55AM +1000, Peter Smith wrote:
> > IIUC for the case ALTER_SUBSCRIPTION_DROP_PUBLICATION it looks like
> > the uninitialized copy_data local stack var would remain uninitialized
> > (undefined) still at the time it is passed at
> > AlterSubscription_refresh(sub, copy_data);
>
> Yes, that's wrong. AlterSubscription_refresh() would happily look at
> this uninitialized value when performing a refresh with this command.
> That's the only code path using parse_subscription_options() with this
> pattern. Applied on HEAD.
>
Hi Michael,
Thank you for this comitt.
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-06-28 11:26:50 | Re: Numeric multiplication overflow errors |
| Previous Message | Ranier Vilela | 2021-06-28 11:05:37 | Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c) |