| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <dgrowleyml(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: define pg_structiszero(addr, s, r) |
| Date: | 2024-11-14 11:22:23 |
| Message-ID: | CAEudQArxZZk2YiZ8nvGym26yTtNoCiS6bTtmdWq1QvKayevOZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qui., 14 de nov. de 2024 às 07:09, Bertrand Drouvot <
bertranddrouvot(dot)pg(at)gmail(dot)com> escreveu:
> Hi,
>
> On Thu, Nov 14, 2024 at 09:27:06AM +0900, Michael Paquier wrote:
> > Makes sense to me to just do that, with a first < 8 loop, and a second
> > for the 8~63 range.
>
> Thanks for looking at it!
>
> > There is also a "cant'" in the last size_t check. Simple typo.
>
> Please find attached v12, with more comments and comments changes to
> explain
> the multiple cases (for safety) and phases (for efficiency).
>
Is it worth mentioning that pg_memory_is_all_zeros does not work correctly
on 32-bit systems?
(63 < (size_t) * 8) /* 63 - 32*/
Or do we adjust magic constants according to 32/64 bit?
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-11-14 11:35:30 | Re: altering a column's collation leaves an invalid foreign key |
| Previous Message | Aleksander Alekseev | 2024-11-14 11:04:57 | Re: [PATCH] Refactor SLRU to always use long file names |