Re: Possible pointer var TupleDesc rettupdesc used not initialized (src/backend/optimizer/util/clauses.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible pointer var TupleDesc rettupdesc used not initialized (src/backend/optimizer/util/clauses.c)
Date: 2021-05-25 11:51:38
Message-ID: CAEudQAraSRf2ojo3KLZjZNzD2c9Uq-d=Kw9p8NMmz9Dkwb4DPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em seg., 24 de mai. de 2021 às 23:35, Zhihong Yu <zyu(at)yugabyte(dot)com>
escreveu:

>
>
> On Mon, May 24, 2021 at 7:21 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
>> Em seg., 24 de mai. de 2021 às 22:42, Mark Dilger <
>> mark(dot)dilger(at)enterprisedb(dot)com> escreveu:
>>
>>>
>>>
>>> > On May 24, 2021, at 5:37 PM, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
>>> wrote:
>>> >
>>> > Hi,
>>> >
>>> > Possible pointer TupleDesc rettupdesc used not initialized?
>>> >
>>> > if (!isNull) at line 4346 taking a true branch, the function
>>> check_sql_fn_retval at line 4448 can use rettupdesc uninitialized.
>>>
>>> Care to submit a patch?
>>>
>> Hi Mark, sorry but not.
>> I examined the code and I can't say what the correct value is for
>> rettupdesc.
>>
>
> Hi,
> It seems the following call would fill up value for rettupdesc :
>
> functypclass = get_expr_result_type((Node *) fexpr, NULL, &rettupdesc);
>
In short, do you suggest running half the else?
To do this, you need to fill fexpr correctly.
It will not always be a trivial solution.

regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-05-25 12:16:10 Re: Assertion failure while streaming toasted data
Previous Message David Rowley 2021-05-25 11:42:44 Re: How can the Aggregation move to the outer query