Re: Speedup usages of pg_*toa() functions

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Speedup usages of pg_*toa() functions
Date: 2020-06-09 21:50:07
Message-ID: CAEudQArZXgrFShBEd49r7kxHsFz1J7v9AKhZ2HTHeZ5WOjRryg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em ter., 9 de jun. de 2020 às 17:42, Andrew Gierth <
andrew(at)tao11(dot)riddles(dot)org(dot)uk> escreveu:

> >>>>> "Ranier" == Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
>
> Ranier> So I would change, just the initialization (var uvalue), even
> though it is
> Ranier> irrelevant.
>
> Ranier> int
> Ranier> pg_lltoa(int64 value, char *a)
> Ranier> {
> Ranier> int len = 0;
> Ranier> uint64 uvalue;
>
> Ranier> if (value < 0)
> Ranier> {
> Ranier> uvalue = (uint64) 0 - uvalue;
>
> Use of uninitialized variable.
>
Sorry, my mistake.

uvalue = (uint64) 0 - value;

regards,
Ranier Vilela

>
> --
> Andrew (irc:RhodiumToad)
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-06-09 22:02:25 Re: Fast DSM segments
Previous Message Robert Haas 2020-06-09 21:06:25 Re: Why is pq_begintypsend so slow?