Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)
Date: 2022-02-14 11:05:42
Message-ID: CAEudQAquHvoMPAr0JgxP5QBiB+cUJe0wCV92jw-NitG+hZWgEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em dom., 13 de fev. de 2022 às 23:07, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:

> On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> > The proposed change is incomplete anyway once you consider this
> > argument. First, there is no need to set up those fields in
> > EndPrepare() anymore if there is no origin data, no? It would be good
> > to comment that these are filled in EndPrepare(), I guess, once you do
> > the initialization in StartPrepare().
>
> That still looked better on a fresh look in terms of consistency, so
> applied this way.
>
Thanks.

regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-02-14 11:58:02 Re: Optionally automatically disable logical replication subscriptions on error
Previous Message Frédéric Yhuel 2022-02-14 10:56:44 Re: Allow parallel plan for referential integrity checks?