| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c) |
| Date: | 2024-05-22 14:44:32 |
| Message-ID: | CAEudQAqh_RZqoFcYKso5d9VhF-Vd64_ZodfQ_2zSusszkEmyRg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
Per Coverity.
2. returned_null: SearchSysCacheAttName returns NULL (checked 20 out of 21
times).
3. var_assigned: Assigning: ptup = NULL return value from
SearchSysCacheAttName.
964 ptup = SearchSysCacheAttName(relid, attname);
CID 1545986: (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing ptup, which is known to be NULL.
The functions SearchSysCacheAttNum and SearchSysCacheAttName,
need to have the result checked.
The commit 5091995
<https://github.com/postgres/postgres/commit/509199587df73f06eda898ae13284292f4ae573a>,
left an oversight.
Fixed by the patch attached, a change of style, unfortunately, was
necessary.
best regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| fix-catalog-cache-search-check.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-05-22 14:48:12 | Re: Avoid orphaned objects dependencies, take 3 |
| Previous Message | Robert Haas | 2024-05-22 14:32:32 | Re: State of pg_createsubscriber |