| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, chap(at)anastigmatix(dot)net |
| Subject: | Re: Should we remove -Wdeclaration-after-statement? |
| Date: | 2024-01-29 16:39:32 |
| Message-ID: | CAEudQAqfsbr1CUdNW788LSYveS==PvhJwjg6AMPfMGSsAuSo7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em seg., 29 de jan. de 2024 às 12:03, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
escreveu:
> I feel like this is the type of change where there's not much
> discussion to be had. And the only way to resolve it is to use some
> voting to gauge community opinion.
>
> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
> +1 to indicate support against/for the change.
>
> I'll start: +1
>
> Attached is a patch that removes -Wdeclaration-after-statement in the
> codebase.
-1
C89 IMO is the best for C readability.
None surprise, once you read the block declaration,
You know all about the vars in the function.
Best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steve Chavez | 2024-01-29 16:54:45 | Re: psql: add \create_function command |
| Previous Message | Ranier Vilela | 2024-01-29 16:30:47 | Optmize bitmapword macros calc (src/backend/nodes/bitmapset.c) |