| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix resource leak (src/backend/libpq/be-secure-common.c) |
| Date: | 2024-04-02 18:13:19 |
| Message-ID: | CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Per Coverity.
Coverity reported a resource leak at the function
run_ssl_passphrase_command.
7. alloc_fn: Storage is returned from allocation function
wait_result_to_str.["show details"]
8. noescape: Assuming resource wait_result_to_str(pclose_rc) is not freed
or pointed-to as ellipsis argument to errdetail_internal.
CID 1533043: (#1 of 1): Resource leak (RESOURCE_LEAK)
9. leaked_storage: Failing to save or free storage allocated by
wait_result_to_str(pclose_rc) leaks it.
I think that Coverity is right.
Fix by freeing the pointer, like pclose_check (src/common/exec.c) similar
case.
Patch attached.
best regards,
| Attachment | Content-Type | Size |
|---|---|---|
| fix-resource-leak-be-secure-common.patch | application/octet-stream | 697 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-04-02 18:22:55 | Re: using extended statistics to improve join estimates |
| Previous Message | Tom Lane | 2024-04-02 17:43:48 | Re: Popcount optimization using AVX512 |