| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid possible memory leak (src/common/rmtree.c) |
| Date: | 2023-07-31 23:10:55 |
| Message-ID: | CAEudQAqGn33+p=ZtaGUBTEUYc1727xaN6vbRkBPu+61dXPiM9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em sex, 28 de jul de 2023 11:54 PM, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:
> On Tue, Jul 25, 2023 at 04:45:22PM +0200, Daniel Gustafsson wrote:
> > Skimming the tree there doesn't seem to be any callers which aren't
> exiting or
> > ereporting on failure so the real-world impact seems low. That being
> said,
> > silencing static analyzers could be reason enough to delay allocation.
>
> A different reason would be out-of-core code that uses rmtree() in a
> memory context where the leak would be an issue if facing a failure
> continuously? Delaying the allocation after the OPENDIR() seems like
> a good practice anyway.
>
Thanks for the commit, Michael.
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-07-31 23:11:38 | Re: pltcl tests fail with FreeBSD 13.2 |
| Previous Message | Andres Freund | 2023-07-31 23:07:41 | Re: pltcl tests fail with FreeBSD 13.2 |