| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SLRU statistics |
| Date: | 2020-05-13 20:08:39 |
| Message-ID: | CAEudQApYCywwJJiYZNmpzp5s0vvWWKe=xfF-RVGxy5uC3PLkDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qua., 13 de mai. de 2020 às 11:46, Fujii Masao <
masao(dot)fujii(at)oss(dot)nttdata(dot)com> escreveu:
>
>
> On 2020/05/13 23:26, Tom Lane wrote:
> > Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> >> On 2020/05/13 17:21, Tomas Vondra wrote:
> >>> On Wed, May 13, 2020 at 04:10:30PM +0900, Fujii Masao wrote:
> >>>> Also I found another minor issue; SLRUStats has not been initialized
> to 0
> >>>> and which could update the counters unexpectedly. Attached patch fixes
> >>>> this issue.
> >
> >> Pushed both. Thanks!
> >
> > Why is that necessary? A static variable is defined by C to start off
> > as zeroes.
>
> Because SLRUStats is not a static variable. No?
>
IMHO, BgWriterStats have the same problem, shouldn't the same be done?
/* Initialize BgWriterStats to zero */
MemSet(&BgWriterStats, 0, sizeof(BgWriterStats));
/* Initialize SLRU statistics to zero */
memset(&SLRUStats, 0, sizeof(SLRUStats));
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2020-05-13 20:14:03 | Re: JSON output from psql |
| Previous Message | Robert Haas | 2020-05-13 19:50:13 | Re: JSON output from psql |