Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)
Date: 2021-07-02 21:22:56
Message-ID: CAEudQApTd4w8vHOgZAfgFeCNoes-hgc6BhwHHXqDS=K3Orm-Uw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em qui., 1 de jul. de 2021 às 17:20, Mahendra Singh Thalor <
mahi6run(at)gmail(dot)com> escreveu:

> On Fri, 2 Jul 2021 at 01:13, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > The function FreePageManagerPutInternal can access an uninitialized
> variable,
> > if the following conditions occur:
>
> Patch looks good to me.
>
> > 1. fpm->btree_depth != 0
> > 2. relptr_off == 0 inside function (FreePageBtreeSearch)
> >
> > Perhaps this is a rare situation, but I think it's worth preventing.
>
> Please can we try to hit this rare condition by any test case. If you have
> any test cases, please share.
>
Added to Commitfest (https://commitfest.postgresql.org/34/3236/) so we
don't forget.

regards,
Ranier Vilela

>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-07-02 21:33:39 Re: psql - factor out echo code
Previous Message Alvaro Herrera 2021-07-02 21:07:50 Re: psql - factor out echo code