| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c) |
| Date: | 2023-09-10 21:28:08 |
| Message-ID: | CAEudQApQE3EnV3QiO-GP95LLs8MRby=cqxqe5+93P_EJRkB+Sw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em sex., 8 de set. de 2023 às 03:24, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:
> On Wed, Sep 06, 2023 at 07:57:03AM -0300, Ranier Vilela wrote:
> > I think no one objected.
>
> Looking closer, there is much more inconsistency in this file
> depending on the routine called. How about something like the v2
> attached instead to provide more context in the error message about
> the function called?
+1
But as Jeff mentioned, when the locale is NULL,
the provider is known to be COLLPROVIDER_LIBC.
I think we can use this to provide an error message,
when the locale is NULL.
What do you think about v3 attached?
best regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| pglocale-elogs-v3.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-09-10 22:24:27 | Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c) |
| Previous Message | Pavel Stehule | 2023-09-10 20:59:01 | Re: proposal: psql: show current user in prompt |